Skip to content

Ready status priority#758

Merged
leochr merged 1 commit into
mainfrom
ready-status-priority
Jun 1, 2026
Merged

Ready status priority#758
leochr merged 1 commit into
mainfrom
ready-status-priority

Conversation

@miuponn
Copy link
Copy Markdown
Contributor

@miuponn miuponn commented Mar 12, 2026

What this PR does / why we need it?:

  • Added test block in utils for checking the sort() block in SetCondition for setting Ready status as conditions[0]
  • Unit testing for merged #717

Does this PR introduce a user-facing change?

  • User guide
  • CHANGELOG.md

Which issue(s) this PR fixes:

Fixes #

@leochr leochr requested a review from halim-lee May 29, 2026 19:46
Comment thread utils/status_test.go Outdated
Copy link
Copy Markdown
Collaborator

@halim-lee halim-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor typo, looks good otherwise!

@miuponn miuponn force-pushed the ready-status-priority branch from ce12b42 to 06335c8 Compare June 1, 2026 16:05
@miuponn miuponn requested a review from halim-lee June 1, 2026 16:11
Copy link
Copy Markdown
Collaborator

@halim-lee halim-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@leochr leochr merged commit bcd7417 into main Jun 1, 2026
@leochr leochr deleted the ready-status-priority branch June 1, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants